Fix example files #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: Missing class call in example files #41 The ipython notebooks were not being tested. This led to an error in the example notebooks which are now fixed. The testing of any ipynb notebooks checked into the repo has also been added.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 86.14% 88.25% +2.10%
==========================================
Files 8 8
Lines 1992 1992
==========================================
+ Hits 1716 1758 +42
+ Misses 276 234 -42
|
matplotlib missing
dbhart
commented
Oct 3, 2024
tzeitle
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41. The examples had errors that were not caught during the CI testing. In addition to fixing the errors, the CI testing was improved so that these errors could be caught in the future.